Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: times should be in seconds #144

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix: times should be in seconds #144

merged 1 commit into from
Mar 18, 2025

Conversation

simoneb
Copy link
Member

@simoneb simoneb commented Mar 18, 2025

Fixes #140

@simoneb simoneb requested review from Copilot and agubler March 18, 2025 16:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the issue of handling test times by converting durations from milliseconds to seconds.

  • Introduces a new end-to-end test to ensure test times are reported in seconds.
  • Updates XML building logic to convert durations from milliseconds to seconds.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
test/e2e/compare-time.js Adds e2e test verifying test durations in seconds.
lib/build-xml.js Converts duration values to seconds for XML output.
Files not reviewed (1)
  • package.json: Language not supported

Copy link

@agubler agubler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@simoneb
Copy link
Member Author

simoneb commented Mar 18, 2025

Thanks @agubler , I had to come up with a simple heuristic to validate that times are converted, because there isn't a way to check that they are "right", only to check that they seem sensible.

@simoneb simoneb merged commit 4be3232 into master Mar 18, 2025
3 checks passed
@simoneb simoneb deleted the fix/time-in-seconds branch March 18, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time field should be in seconds, seems to be milliseconds
2 participants