only capture stdout not stdout+stderr when capture_output=True #2704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally was trying to parse stdout + stderr as json instead of just stdout when capture_output=True. This PR fixes that.
Reference Issues or PRs
Fixes failing deployment tests
I validated the idea by re-running one of them and it worked - https://github.com/nebari-dev/nebari/actions/runs/10689796315
Azure now seems to be failing for an unrelated reason - https://github.com/nebari-dev/nebari/actions/runs/10691605764
GCP redeployment - https://github.com/nebari-dev/nebari/actions/runs/10691927249
What does this implement/fix?
Put a
x
in the boxes that applyTesting
How to test this PR?
Do a local deployment with the "TF_LOG" env var set to "TRACE"
Any other comments?