Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only capture stdout not stdout+stderr when capture_output=True #2704

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Sep 3, 2024

I accidentally was trying to parse stdout + stderr as json instead of just stdout when capture_output=True. This PR fixes that.

Reference Issues or PRs

Fixes failing deployment tests

I validated the idea by re-running one of them and it worked - https://github.com/nebari-dev/nebari/actions/runs/10689796315
Azure now seems to be failing for an unrelated reason - https://github.com/nebari-dev/nebari/actions/runs/10691605764
GCP redeployment - https://github.com/nebari-dev/nebari/actions/runs/10691927249

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Do a local deployment with the "TF_LOG" env var set to "TRACE"

Any other comments?

Copy link
Contributor

@viniciusdc viniciusdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would like to wait for the local tests before merging

@Adam-D-Lewis Adam-D-Lewis merged commit 0952cf8 into develop Sep 4, 2024
29 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the deployment-test-fixes branch September 4, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants