Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tofu binary instead of terraform one #2773

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

marcelovilla
Copy link
Member

@marcelovilla marcelovilla commented Oct 14, 2024

Reference Issues or PRs

Closes #2762

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

I think there are two important things to test with this PR: (1) deploy from scratch using the OpenTofu binary, and (2) upgrade an existing cluster using the OpenTofu binary. To test:

  1. Deploy Nebari off of this branch, either locally or to any of the supported cloud providers.
  2. Upgrade an existing Nebari deployment using this branch and redeploy

All resources should be correctly deployed and Nebari should be running as usual after.

Any other comments?

This has been successfully tested in the following scenarios:

@marcelovilla marcelovilla marked this pull request as ready for review November 6, 2024 15:22
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested an upgrade? I think we should test one on an existing deployment just to be sure no issues will arise.

@marcelovilla
Copy link
Member Author

Have you tested an upgrade? I think we should test one on an existing deployment just to be sure no issues will arise.

@Adam-D-Lewis I did test an upgrade on GCP and everything went smooth. I still think it would be worthwhile to test both an AWS and Azure upgrade

@Adam-D-Lewis Adam-D-Lewis self-requested a review November 7, 2024 16:21
@marcelovilla
Copy link
Member Author

Here's a passing local upgrade test: https://github.com/nebari-dev/nebari/actions/runs/11740475035/job/32707098771

Copy link
Contributor

@dcmcand dcmcand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with clean install and upgrade from 2024.7.1. Does what it says on the tin. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

[ENH] - Switch from Terraform to OpenTofu
3 participants