loosen dependency requirement pins for nebari #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-D-Lewis
requested review from
dcmcand and
viniciusdc
and removed request for
a team
Adam-D-Lewis
changed the title
Adam-D-Lewis
commented
Mar 10, 2025
Comment on lines
-60
to
-62
| # Mock the provider field to be immutable | ||
| mock_model_fields.__getitem__.return_value.json_schema_extra = {"immutable": True} | ||
|
|
There was a problem hiding this comment.
provider field is already marked as immutable, so this is not necessary to mock it
viniciusdc
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
The dependencies in pyproject.toml are overly restrictive. I built a plugin that requires slight adjustments to a few dependencies. This PR makes those changes to the dependency pins in pyproject.toml.
Alternatively, pinning the depedencies to the new versions that my env solved for would still work for me if you want to keep the pins tight (but on new versions).
This PR also fixes some broken CICD - #2985.
What does this implement/fix?
Put a
xin the boxes that applyTesting
How to test this PR?
Any other comments?