Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage of 32-bit ARM build. #308

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

saurik
Copy link

@saurik saurik commented Nov 12, 2024

While some platforms support @progbits with a @, as far as I can tell all support it with %. Notably, 32-bit ARM (armeabi-v7a for Android, in my case) seems to not support the @.

<inline asm>:1:41: error: expected '%<type>' or "<type>"
    1 | .pushsection ".debug_gdb_scripts", "MS",@progbits,1
      |                                         ^
<inline asm>:101:12: error: .popsection without corresponding .pushsection
  101 | .popsection
      |            ^
2 errors generated.

This is (I presume) the actual underlying cause of the Android issue that was fixed in ebcd267, but it doesn't only affect Android: I'm also getting this when trying to compile for 32-bit ARM desktop Linux systems. I've thereby also removed the new !ANDROID ifdef as part of this fix.

@ned14
Copy link
Owner

ned14 commented Nov 12, 2024

Thanks for this. Didn't realise that @ = % would fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants