chore: [5.x] remove deprecations #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 5.x #2388 +/- ##
==========================================
+ Coverage 89.48% 95.49% +6.01%
==========================================
Files 74 71 -3
Lines 2825 2577 -248
==========================================
- Hits 2528 2461 -67
+ Misses 297 116 -181 ☔ View full report in Codecov by Sentry. |
DjordyKoert
commented
Nov 12, 2024
| */ | ||
| public function supports(array $types): bool; | ||
| public function supports(array $types, array $context = []): bool; |
There was a problem hiding this comment.
TODO: This needs to be added as an optional parameter on 4.x as well
9 tasks
DjordyKoert
added a commit
that referenced
this pull request
Nov 12, 2024
## Description #2388 (comment) ## What type of PR is this? (check all applicable) - [ ] Bug Fix - [ ] Feature - [x] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [ ] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes all deprecations from
4.xWhat type of PR is this? (check all applicable)
Checklist
docs/)CHANGELOG.md)