Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use custom request matcher #241

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

ihmels
Copy link
Contributor

@ihmels ihmels commented Jun 24, 2021

This adds an option to allow the use of a custom request matcher, e.g. to exclude certain paths.

This fixes #206 partially.

@tooltonix
Copy link

I need this feature urgently at the moment, please merge.

@Seldaek
Copy link
Member

Seldaek commented Aug 24, 2021

This would need to be added to the docs still, and ideally it should be made clear that using this renders the hosts option useless/unused.

@ihmels
Copy link
Contributor Author

ihmels commented Oct 7, 2021

I added the request_matcher option to the docs. While writing this, I noticed that it also makes sense to ignore the content_types option when a custom RequestMatcher has been configured.

This adds an option to allow the use of a custom
request matcher, e.g. to exclude certain paths.
@ihmels
Copy link
Contributor Author

ihmels commented May 21, 2024

@Seldaek, can you take another look at this?

@Seldaek
Copy link
Member

Seldaek commented Jun 27, 2024

Yeah, sorry we're not as responsive as we could be here.. But anyway the PR looks good to me now I think! Thanks

@Seldaek Seldaek merged commit 6e3fd83 into nelmio:master Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Per-page CSP configuration
3 participants