Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AppIndicator3 and AyatanaAppIndicator3 #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

HeavenVolkoff
Copy link

Hello,

This PR adds GIR and VAPI definitions for libappindicator3. Used to create tray icons with gtk3.

https://launchpad.net/libappindicator

Copy link
Collaborator

@ricotz ricotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeavenVolkoff
Copy link
Author

Hello @ricotz,

Thanks for reviewing this PR.

I added definitions for AyatanaIdo3 and AyatanaAppIndicator3. Should I also remove the definitions for AppIndicator3? I know it was superseded, however it seems to still be widely used and not completely abandoned (last commit was from 2020). Also, AyatanaAppIndicator3 is not yet available on all majors distros (e.g.: Fedora), and I have seen projects which do fallback builds with AppIndicator3 when AyatanaAppIndicator3 isn't found on the system, so maybe it is worth keeping it with a deprecated notice of some sort?

@HeavenVolkoff HeavenVolkoff requested a review from ricotz November 29, 2022 20:13
@HeavenVolkoff HeavenVolkoff changed the title Add AppIndicator3 Add AppIndicator3 and AyatanaAppIndicator3 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants