Add kontonummer fallback to HIUPDv6 if IBAN is not available #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philipp91
approved these changes
Nov 26, 2025
ampaze
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After migrating to
GetStatementOfAccountXML, we encountered this error when fetching transactions from Sparkasse Koblenz:This happens because Sparkasse Koblenz does not provide an IBAN in its
HIUPDv6.This PR fixes this issue by falling back to the kontonummer as
HIUPDv4did.It also fixes a deprecated warning in
Serializerby callingself::classinstead of using'self' as a string and adds.vscodeto.gitignore.