Adds bailing heuristic for symbol table calc + test #590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at a bailing heuristic. The first simple idea we have here, is to bail unless we write a non-letter/number.
This way, it's not until you have finished a label/reltype in queries like
MATCH (n:Person)
(not triggered forP
,Pe
etc, but triggered at)
in the node pattern)or
MATCH (n:Person)-[:KNOWS]
(triggered at]
) in the rel pattern)This both reduces unnecessary recalculations from using computer resources, but also prevents us from waiting for the calculation from an unfinished node pattern etc before starting the calculation for the finished pattern.
The downside is for example if one changes only the label of a node. Then one would not need to close the pattern/continue the path - heuristic would skip symbol table update - but the symbol table would actually be outdated