Skip to content

Images refresh batch 2 #2541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Images refresh batch 2 #2541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
399a3a6
Images refresh batch 2
lidiazuin Aug 15, 2025
86a6ef6
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Aug 15, 2025
ed6b904
Add documentation for the alter database privileges on database level…
Hunterness Aug 19, 2025
fc82a2d
Update the description of the history option (#2543)
NataliaIvakina Aug 19, 2025
fe668fb
Add tabbed examples for multiple node IDs (#2512)
NataliaIvakina Aug 20, 2025
879932c
Images refresh batch 2
lidiazuin Aug 15, 2025
bfb7692
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Aug 21, 2025
3a9c6f0
reviewed images after feedback
lidiazuin Aug 28, 2025
ed698cb
review after feedback
lidiazuin Aug 29, 2025
41136da
Merge branch 'dev' into imgrefresh-batch2
lidiazuin Sep 1, 2025
50c621f
update of image
lidiazuin Sep 4, 2025
dbb011c
update image after review
lidiazuin Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed modules/ROOT/images/backup-chain-aggregate.png
View file
Open in desktop
Binary file not shown.
69 changes: 69 additions & 0 deletions modules/ROOT/images/privileges-grant-and-deny-syntax-database-privileges.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
88 changes: 88 additions & 0 deletions modules/ROOT/images/privileges-grant-and-deny-syntax-dbms-privileges.svg
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 17 15

Copy link
Collaborator

@renetapopova renetapopova Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 19 37

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image I think some of your image comments doesn't load?

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
25 changes: 25 additions & 0 deletions modules/ROOT/images/privileges-grant-and-deny-syntax-load-privileges.svg
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no space between To role and [,...] in the original diagram. @Hunterness, is the space a problem?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it matters as such but generally I'd not have a space there if I write the command even if it parses (... TO role1, role2 vs ... TO role1 , role2) 🤷

I'll also say that if the other syntax images doesn't have the space I don't think we should have it here but be consistent about it

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
76 changes: 76 additions & 0 deletions modules/ROOT/images/privileges-hierarchy-database.svg
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alter database is missing
Screenshot 2025-09-08 at 13 04 42

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2541 (comment) I also noticed this :P

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
240 changes: 240 additions & 0 deletions modules/ROOT/images/privileges-hierarchy-dbms.svg
View file
Open in desktop
Copy link
Collaborator

@renetapopova renetapopova Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 31 37

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The connections that you noted that don't derive from the same place are all coming from ALL DBMS PRIVILEGES, that's the style of the arrows used in the technical diagrams. I can try to change the style, but just letting you know that this is the default styling.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought so, but they look misleading, so I decided to tell you if you can change them somehow.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
47 changes: 47 additions & 0 deletions modules/ROOT/images/privileges-hierarchy.svg
View file
Open in desktop
Copy link
Collaborator

@renetapopova renetapopova Sep 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-08 at 13 54 58

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion modules/ROOT/images/privileges_grant_and_deny_syntax_database_privileges.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion modules/ROOT/images/privileges_grant_and_deny_syntax_dbms_privileges.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion modules/ROOT/images/privileges_grant_and_deny_syntax_load_privileges.svg
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions modules/ROOT/images/privileges_hierarchy.svg
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion modules/ROOT/images/privileges_hierarchy_dbms.svg
View file
Open in desktop

This file was deleted.

8 changes: 2 additions & 6 deletions modules/ROOT/pages/authentication-authorization/database-administration.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,10 +187,7 @@ See link:{neo4j-docs-base-uri}/status-codes/{page-version}/notifications/all-not
The hierarchy between the different database privileges is shown in the image below.

// TODO: do we want two pictures, one for Cypher 5 and one for Cypher 25? I'd guess not but I'm not sure
image::privileges_hierarchy_database.svg[title="Database privileges hierarchy"]



image::privileges-hierarchy-database.svg[title="Database privileges hierarchy"]

.`GRANT ACCESS` privilege syntax
[cols="<15s,<85"]
Expand Down Expand Up @@ -529,8 +526,7 @@ GRANT [IMMUTABLE] TRANSACTION [MANAGEMENT] [( { * \| user[, ...] } )]
|===

// TODO: do we want two pictures, one for Cypher 5 and one for Cypher 25? I'd guess not but I'm not sure
image::privileges_grant_and_deny_syntax_database_privileges.svg[title="Syntax of `GRANT` and `DENY` database privileges"]

image::privileges-grant-and-deny-syntax-dbms-privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image::privileges-grant-and-deny-syntax-dbms-privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]
image::privileges-grant-and-deny-syntax-database-privileges.svg[width="800", title="Syntax of `GRANT` and `DENY` database privileges"]


[[access-control-database-administration-access]]
== The database `ACCESS` privilege
Expand Down
4 changes: 2 additions & 2 deletions modules/ROOT/pages/authentication-authorization/dbms-administration.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ All DBMS privileges are relevant system-wide.
Like user management, they do not belong to one specific database or graph.
For more details on the differences between graphs, databases, and the DBMS, refer to link:{neo4j-docs-base-uri}/cypher-manual/current/introduction/cypher-neo4j/[Cypher Manual -> Cypher and Neo4j].

image::privileges_grant_and_deny_syntax_dbms_privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]
image::privileges-grant-and-deny-syntax-dbms-privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image::privileges-grant-and-deny-syntax-dbms-privileges.svg[width="800", title="Syntax of GRANT and DENY DBMS privileges"]
image::privileges-grant-and-deny-syntax-dbms-privileges.svg[width="800", title="Syntax of `GRANT` and `DENY` DBMS privileges"]


image::privileges_hierarchy_dbms.svg[width="800", title="DBMS privileges hierarchy"]
image::privileges-hierarchy-dbms.svg[width="800", title="DBMS privileges hierarchy", role=popup]

[NOTE]
====
Expand Down
2 changes: 1 addition & 1 deletion modules/ROOT/pages/authentication-authorization/load-privileges.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ All load privileges apply to the whole system.
Like DBMS privileges, they do not belong to one specific database or graph.
For more details on the differences between graphs, databases, and the DBMS, refer to link:{neo4j-docs-base-uri}/cypher-manual/current/introduction/cypher-neo4j/[Cypher Manual -> Cypher and Neo4j].

image::privileges_grant_and_deny_syntax_load_privileges.svg[width="800", title="Syntax of GRANT and DENY load Privileges"]
image::privileges-grant-and-deny-syntax-load-privileges.svg[width="800", title="Syntax of GRANT and DENY load Privileges", role=popup]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
image::privileges-grant-and-deny-syntax-load-privileges.svg[width="800", title="Syntax of GRANT and DENY load Privileges", role=popup]
image::privileges-grant-and-deny-syntax-load-privileges.svg[width="800", title="Syntax of `GRANT` and `DENY` load privileges", role=popup]


// TODO: add image later when there is more than one LOAD privilege
//image::privileges_hierarchy_load.svg[title="Load privileges hierarchy"]
Expand Down
2 changes: 1 addition & 1 deletion modules/ROOT/pages/authentication-authorization/manage-privileges.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ image::privileges_on_graph_syntax.svg[width="800", title="Syntax of GRANT and DE

The following image shows the hierarchy between different graph privileges:

image::privileges_hierarchy.svg[title="Graph privileges hierarchy"]
image::privileges-hierarchy.svg[title="Graph privileges hierarchy", role=popup]



Expand Down