feat(acquisition): apply acquisition timeout immediately #1685
+44
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/acquisition
branch
6 times, most recently
from
69800c9 to
e5b59f0
Compare
BREAKING CHANGE: `org.neo4j.driver.Config.ConfigBuilder#withConnectionAcquisitionTimeout(long, TimeUnit)` no longer accepts negative values. In addition, the acquisition timeout is applied immediately for the entire connection acquisition process that may include client-side routing and other logic. Previously, the connection acquisition timeout applied individually for every acquisition from individual connection pools and only when all connections were busy.
injectives
force-pushed
the
feature/acquisition
branch
from
e5b59f0 to
ad13ed8
Compare
injectives
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
org.neo4j.driver.Config.ConfigBuilder#withConnectionAcquisitionTimeout(long, TimeUnit)no longer accepts negative values. In addition, the acquisition timeout is applied immediately for the entire connection acquisition process that may include client-side routing and other logic. Previously, the connection acquisition timeout applied individually for every acquisition from individual connection pools and only when all connections were busy.