Failing spec for interrupts and exceptions

ruby/neo4j/driver/internal/async/network_connection.rb

@@ -16,7 +16,7 @@ def initialize(channel, channel_pool, logger, &on_pool_shutdown)
           @server_version = channel.attributes[:server_version]
           @protocol = Messaging::BoltProtocol.for_channel(channel)
           @channel_pool = channel_pool
-          @on_pool_shutdow = on_pool_shutdown
+          @on_pool_shutdown = on_pool_shutdown
           # @release_future = java.util.concurrent.CompletableFuture.new
           # @clock = clock
           # @connection_read_timeout = Connection::ChannelAttributes.connection_read_timeout(channel) || nil
@@ -104,7 +104,7 @@ def write_to_channel(message, flush = false)
           terminate_and_release(e.message)
           @log.debug("Shutting down connection pool towards #{@server_address} due to error: #{e.message}")
           @channel_pool.shutdown(&:close)
-          @on_pool_shutdow.call
+          @on_pool_shutdown.call
           # should remove routing table entry as well
           raise Exceptions::SessionExpiredException, e.message
         end

spec/integration/threads_use_cases_spec.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+RSpec.describe 'Session' do
+  describe 'thread interrupted after acquiring connection' do
+    context 'with thread#raise' do
+      it 'releases connection back into pool' do
+        driver = Neo4j::Driver::GraphDatabase.driver(uri, basic_auth_token)
+        session = driver.session
+        session.read_transaction {}
+
+        channel_pool = DriverInternalDataAccessor.channel_pool_from_session(session)
+        expect(channel_pool.busy?).to be false
+
+        thr = Thread.new { session.read_transaction { |_tx| sleep(60) } }
+
+        wait_for { !channel_pool.busy? }
+        expect(channel_pool.busy?).to be true
+        thr.raise("Bhadako!")
+
+        wait_for { channel_pool.busy? }
+        expect(channel_pool.busy?).to be false
+      end
+    end
+
+    context 'with thread#kill' do
+      it 'releases connection back into pool' do
+        driver = Neo4j::Driver::GraphDatabase.driver(uri, basic_auth_token)
+        session = driver.session
+        session.read_transaction {}
+
+        channel_pool = DriverInternalDataAccessor.channel_pool_from_session(session)
+        expect(channel_pool.busy?).to be false
+
+        thr = Thread.new { session.read_transaction { |_tx| sleep(60) } }
+
+        wait_for { !channel_pool.busy? }
+        expect(channel_pool.busy?).to be true
+        thr.kill
+
+        wait_for { channel_pool.busy? }
+        expect(channel_pool.busy?).to be false
+      end
+    end
+  end
+end

spec/spec_helper.rb

@@ -11,6 +11,8 @@
 require 'rspec/its'
 require 'support/driver_helper'
 require 'support/neo4j_cleaner'
+require 'support/driver_internal_data_accessor'
+require 'support/timeout_helper'
 
 RSpec.configure do |config|
   # Enable flags like --only-failures and --next-failure
@@ -28,6 +30,7 @@
   # config.include Neo4jCleaner
   include DriverHelper::Helper
   include Neo4jCleaner
+  include TimeoutHelper
   config.define_derived_metadata do |metadata|
     metadata[:timeout] = 9999
   end

spec/support/driver_internal_data_accessor.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module DriverInternalDataAccessor
+  def self.channel_pool_from_session(session)
+    session.instance_variable_get(:@session).instance_variable_get(:@connection).connection.instance_variable_get :@channel_pool
+  end
+
+  def self.channel_pool_from_driver(driver, uri)
+    hash = driver.session_factory.connection_provider.instance_variable_get(:@connection_pool).instance_variable_get(:@address_to_pool)
+    hash.find { |address, channel_pool| address.uri == uri }.last
+  end
+end

spec/support/timeout_helper.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+
+module TimeoutHelper
+  def wait_for(timeout = 4, sleep_interval = 0.01, &condition)
+    Timeout.timeout(timeout) { sleep(sleep_interval) while(condition.call) }
+  end
+end