Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential histogram #9003

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Exponential histogram #9003

wants to merge 6 commits into from

Conversation

knizhnik
Copy link
Contributor

Problem

Current LFC size is specified based on sliding Hyper-log-log working set size estimation which doesn't take in account access frequency. For example there can be multiple OLTP queries working with most recent subset of theta and one slow OLAP query running in background which traverse all historical data. Currently working set size estimation will be the same as the whole database size.

Summary of changes

Use exponential histograms to calculate minimal cache size providing required hit ratio: hits/(hits + misses) relation.
For example with min hit ration 0.99, pages which access frequency is less than 1% of all accessed pages, will not be included in working set estimation

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

@knizhnik knizhnik requested review from a team as code owners September 15, 2024 06:28
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

Copy link

github-actions bot commented Sep 15, 2024

No tests were run or test report is not available

Test coverage report is not available

The comment gets automatically updated with the latest test results
b7015db at 2024-09-19T18:23:51.306Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant