Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Current LFC size is specified based on sliding Hyper-log-log working set size estimation which doesn't take in account access frequency. For example there can be multiple OLTP queries working with most recent subset of theta and one slow OLAP query running in background which traverse all historical data. Currently working set size estimation will be the same as the whole database size.
Summary of changes
Use exponential histograms to calculate minimal cache size providing required hit ratio: hits/(hits + misses) relation.
For example with min hit ration 0.99, pages which access frequency is less than 1% of all accessed pages, will not be included in working set estimation
Checklist before requesting a review
Checklist before merging