-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storcon: update compute hook state on detach #9045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem Previously, the storage controller may send compute notifications containing stale pageservers (i.e. pageserver serving the shard was detached). This happened because detaches did not update the compute hook state. Summary of Changes Update compute hook state on shard detach. Fixes #8928
4994 tests run: 4830 passed, 0 failed, 164 skipped (full report)Flaky tests (8)Postgres 17
Postgres 16
Postgres 15
Postgres 14
Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
9e47dbb at 2024-09-19T13:35:27.005Z :recycle: |
Not entirely sure why would this PR cause this test failure, it has not happened in a long while. |
koivunej
reviewed
Sep 19, 2024
koivunej
reviewed
Sep 19, 2024
koivunej
reviewed
Sep 19, 2024
koivunej
reviewed
Sep 19, 2024
koivunej
reviewed
Sep 19, 2024
koivunej
reviewed
Sep 19, 2024
jcsp
reviewed
Sep 19, 2024
jcsp
approved these changes
Sep 23, 2024
jcsp
reviewed
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Previously, the storage controller may send compute notifications containing stale pageservers (i.e. pageserver serving the shard was detached). This happened because detaches did not update the compute hook state.
Summary of Changes
Update compute hook state on shard detach.
Fixes #8928