Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storcon: update compute hook state on detach #9045

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

VladLazar
Copy link
Contributor

Problem

Previously, the storage controller may send compute notifications containing stale pageservers (i.e. pageserver serving the shard was detached). This happened because detaches did not update the compute hook state.

Summary of Changes

Update compute hook state on shard detach.

Fixes #8928

Problem

Previously, the storage controller may send compute notifications
containing stale pageservers (i.e. pageserver serving the shard was
detached). This happened because detaches did not update the compute
hook state.

Summary of Changes

Update compute hook state on shard detach.

Fixes #8928
@VladLazar VladLazar requested a review from a team as a code owner September 18, 2024 13:33
@VladLazar VladLazar requested review from yliang412, jcsp and koivunej and removed request for yliang412 September 18, 2024 13:33
Copy link

github-actions bot commented Sep 18, 2024

4994 tests run: 4830 passed, 0 failed, 164 skipped (full report)


Flaky tests (8)

Postgres 17

Postgres 16

Postgres 15

Postgres 14

Code coverage* (full report)

  • functions: 31.8% (7419 of 23308 functions)
  • lines: 49.8% (59586 of 119702 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
9e47dbb at 2024-09-19T13:35:27.005Z :recycle:

@koivunej
Copy link
Member

koivunej commented Sep 19, 2024

Not entirely sure why would this PR cause this test failure, it has not happened in a long while.

@VladLazar VladLazar merged commit 5432155 into main Sep 23, 2024
79 checks passed
@VladLazar VladLazar deleted the vlad/fixup-compute-hook-detach branch September 23, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures in test_scrubber_physical_gc
3 participants