fix(pageserver): receive body error now 500 #9052
Open
+12
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
close #8903
In #8903 we observed JSON decoding error to have the following error message in the log:
This is hard to understand. In this patch, we make the error message more reasonable.
Summary of changes
reqwest::Error
asanyhow::Error
.to_string
, we use the alternativeanyhow::Error
formatting, so that it prints out the cause of the error (i.e., what exactly cannot serde decode).I would expect seeing something like
error receiving body: error decoding response body: XXX field not found
after this patch, though I didn't set up a testing environment to observe the exact behavior.Checklist before requesting a review
Checklist before merging