Skip to content

Correct type of types option to CustomTypesConfig #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andyjy
Copy link
Contributor

@andyjy andyjy commented Nov 6, 2024

Context: #110 (comment)

I've also updated the example in CONFIG.md, although the way pg's types are written seem to require userland use of any on the format parameter and as typeof PgTypes.getTypeParser cast on the custom implementation of getTypeParser(), which is quite displeasing 😭

It may be preferable to keep the current example for simplicity (as it doesn't require these userland typescript workarounds), potentially with a warning about global scope pollution. 🤷‍♂️

@andyjy
Copy link
Contributor Author

andyjy commented Feb 11, 2025

@jawj I would be happy to update this PR for the new refactor if you would like to accept it?

Context/reasoning in the linked issue: #110 (comment)

Small beans really but there is currently a type cast in a fix I wrote for the Prisma Neon adapter that can be removed to tidy things up from a type safety perspective if this is accepted.

@jawj
Copy link
Collaborator

jawj commented Feb 13, 2025

Ditto, thanks, this looks good: will gladly merge if updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants