WIP FEATURE: RequestTags #3471
Draft
WIP FEATURE: RequestTags #3471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a "RequestTag" system, currently fully exposed on the ActionRequest but technically we have the data on the HttpRequest for later changes. The RequestTags are arbitrary but can be used e.g. as RequestPattern matcher. The idea is that you could use the RequestPattern with tags and then anyone wanting to be part of this AuthenticationProvider can just tag their route accordingly. Should also help with the Frontend vs Backend problem in the FrontendLogin package. Other uses TBD, also extensibility (aka other sources for tags). The implementation in the Router is a bit rough, I wanted to make sure there is no way to set this from the outside.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a "RequestTag" system, currently fully exposed on the ActionRequest but technically we have the data on the HttpRequest for later changes.
The RequestTags are arbitrary but can be used e.g. as RequestPattern matcher.
The idea is that you could use the RequestPattern with tags and then anyone wanting to be part of this AuthenticationProvider can just tag their route accordingly.
Should also help with the Frontend vs Backend problem in the FrontendLogin package.
Other uses TBD, also extensibility (aka other sources for tags). The implementation in the Router is a bit rough, I wanted to make sure there is no way to set this from the outside.
Maybe the "type" is just YAGNI and we can remove it again. Was just an idea (the RequestPattern should check it but doesn't atm).