BUGFIX: Redirect handler works with Neos in subdirectory #30
Conversation
Using the RequestInformationHelper ensures that the baseUri includes the script request path (so any sub directory neos might be in).
| @@ -107,7 +107,8 @@ protected function buildResponse(ServerRequestInterface $httpRequest, RedirectIn | |||
| $location = $redirect->getTargetUriPath(); | |||
|
|
|||
| if (parse_url($location, PHP_URL_SCHEME) === null) { | |||
| $location = (string)$httpRequest->getUri()->withQuery('')->withFragment('')->withPath($location); | |||
| $baseUriForRequest = (string)RequestInformationHelper::generateBaseUri($httpRequest); | |||
| $location = rtrim($baseUriForRequest, '/') . '/' . ltrim($location, '/'); | |||
There was a problem hiding this comment.
Wouldn't be better to assure, that the $baseUriForRequest got from that method always has / has not a trailing slash?
There was a problem hiding this comment.
You are right, and actually that is the case. It always has a trailing slash
There was a problem hiding this comment.
Can we be sure that location has (or has not) a leading slash?
There was a problem hiding this comment.
targetUriPath gets a ltrim for slashes in it's constructor.
|
@kitsunet would this also work with the Neos 4.3 compatible 3.x branch? Then you could retarget the PR |
|
@kitsunet Can we close this? Or is this still relevant? |
|
@kitsunet Ping |
|
I'll close this because this might be outdated in meanwhile. Please feel free to re-open if this is still a solution. |
Using the RequestInformationHelper ensures that the baseUri includes the script request path (so any sub directory neos might be in).