BUGFIX: Redirect handler works with Neos in subdirectory #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the RequestInformationHelper ensures that the baseUri includes the script request path (so any sub directory neos might be in).
| @@ -107,7 +107,8 @@ protected function buildResponse(ServerRequestInterface $httpRequest, RedirectIn | |||
| $location = $redirect->getTargetUriPath(); | |||
|
|
|||
| if (parse_url($location, PHP_URL_SCHEME) === null) { | |||
| $location = (string)$httpRequest->getUri()->withQuery('')->withFragment('')->withPath($location); | |||
| $baseUriForRequest = (string)RequestInformationHelper::generateBaseUri($httpRequest); | |||
| $location = rtrim($baseUriForRequest, '/') . '/' . ltrim($location, '/'); | |||
There was a problem hiding this comment.
Wouldn't be better to assure, that the $baseUriForRequest got from that method always has / has not a trailing slash?
There was a problem hiding this comment.
You are right, and actually that is the case. It always has a trailing slash
There was a problem hiding this comment.
Can we be sure that location has (or has not) a leading slash?
There was a problem hiding this comment.
targetUriPath gets a ltrim for slashes in it's constructor.
|
@kitsunet would this also work with the Neos 4.3 compatible 3.x branch? Then you could retarget the PR |
|
@kitsunet Can we close this? Or is this still relevant? |
|
@kitsunet Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the RequestInformationHelper ensures that the baseUri includes the script request path (so any sub directory neos might be in).