Skip to content

feat: enhanced todo implementation #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aeroxy wants to merge 1 commit into from
Closed

feat: enhanced todo implementation #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion browser/src/types/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,48 @@ type TodoWriteReturnDisplay = {
type: 'todo_write';
oldTodos: TodoItem[];
newTodos: TodoItem[];
metadata: {
agentId: string;
version: number;
totalTodos: number;
completedTodos: number;
pendingTodos: number;
inProgressTodos: number;
};
hasCleanupSuggestions?: boolean;
};

type TodoCreateReturnDisplay = {
type: 'todo_create';
agentId: string;
filePath: string;
message: string;
};

type TodoCleanupSuggestionReturnDisplay = {
type: 'todo_cleanup_suggestion';
agentId: string;
completedTodos: TodoItem[];
suggestion: string;
summary: {
totalCompleted: number;
totalRemaining: number;
};
};

type TodoListReturnDisplay = {
type: 'todo_list';
agentId: string;
summary: string;
metadata: {
agentId: string;
version: number;
totalTodos: number;
completedTodos: number;
pendingTodos: number;
inProgressTodos: number;
};
todos: TodoItem[];
};

type DiffViewerReturnDisplay = {
Expand All @@ -99,7 +141,10 @@ export type ToolResult = {
| string
| DiffViewerReturnDisplay
| TodoReadReturnDisplay
| TodoWriteReturnDisplay;
| TodoWriteReturnDisplay
| TodoCreateReturnDisplay
| TodoCleanupSuggestionReturnDisplay
| TodoListReturnDisplay;
isError?: boolean;
};

Expand Down
3 changes: 3 additions & 0 deletions src/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ export const CANCELED_MESSAGE_TEXT = '[Request interrupted by user]';
export enum TOOL_NAMES {
TODO_WRITE = 'todoWrite',
TODO_READ = 'todoRead',
TODO_CREATE = 'todoCreate',
TODO_DELETE = 'todoDelete',
TODO_LIST = 'todoList',
BASH = 'bash',
BASH_OUTPUT = 'bash_output',
KILL_BASH = 'kill_bash',
Expand Down
81 changes: 77 additions & 4 deletions src/tool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,22 @@ export async function resolveTools(opts: ResolveToolsOpts) {
: [];
const todoTools = (() => {
if (!opts.todo) return [];
const { todoWriteTool, todoReadTool } = createTodoTool({
filePath: path.join(paths.globalConfigDir, 'todos', `${sessionId}.json`),
const {
todoCreateTool,
todoWriteTool,
todoReadTool,
todoListTool,
todoDeleteTool,
} = createTodoTool({
baseDir: path.join(paths.globalConfigDir, 'todos'),
});
return [todoReadTool, todoWriteTool];
return [
todoCreateTool,
todoWriteTool,
todoReadTool,
todoListTool,
todoDeleteTool,
];
})();
const backgroundTools = opts.write
? [
Expand Down Expand Up @@ -239,6 +251,63 @@ type TodoWriteReturnDisplay = {
type: 'todo_write';
oldTodos: TodoItem[];
newTodos: TodoItem[];
metadata: {
agentId: string;
version: number;
totalTodos: number;
completedTodos: number;
pendingTodos: number;
inProgressTodos: number;
};
hasCleanupSuggestions?: boolean;
};

type TodoCreateReturnDisplay = {
type: 'todo_create';
agentId: string;
filePath: string;
message: string;
};

type TodoDeleteReturnDisplay = {
type: 'todo_delete';
agentId: string;
deletedTodo: TodoItem;
remainingCount: number;
metadata: {
agentId: string;
version: number;
totalTodos: number;
completedTodos: number;
pendingTodos: number;
inProgressTodos: number;
};
};

type TodoCleanupSuggestionReturnDisplay = {
type: 'todo_cleanup_suggestion';
agentId: string;
completedTodos: TodoItem[];
suggestion: string;
summary: {
totalCompleted: number;
totalRemaining: number;
};
};

type TodoListReturnDisplay = {
type: 'todo_list';
agentId: string;
summary: string;
metadata: {
agentId: string;
version: number;
totalTodos: number;
completedTodos: number;
pendingTodos: number;
inProgressTodos: number;
};
todos: TodoItem[];
};

type DiffViewerReturnDisplay = {
Expand All @@ -253,7 +322,11 @@ export type ReturnDisplay =
| string
| DiffViewerReturnDisplay
| TodoReadReturnDisplay
| TodoWriteReturnDisplay;
| TodoWriteReturnDisplay
| TodoCreateReturnDisplay
| TodoDeleteReturnDisplay
| TodoCleanupSuggestionReturnDisplay
| TodoListReturnDisplay;

export type ToolResult = {
llmContent: string | (TextPart | ImagePart)[];
Expand Down
Loading