fix(svlangserver): don't use custom project setting resolution

[williamboman]

@henry-hsieh 👋 It seems like the server configuration for svlangserver included some custom exrc-as-json-style project settings loader, which I don't think should be part of the stock configuration provided by lspconfig, but instead provided by users themselves.

[henry-hsieh]

Hi @williamboman,
The svlangserver relies LSP client (vscode, coc.nvim, etc.) to provide project local setting. I previously open an issue #1874 to request alternative project local settings because Neovim deprecate exrc after v0.7 (remind me if I'm wrong). Therefore, I created custom exrc-as-json-style project settings loader to do this trick.

I thought that the on_init function could be removed in lspconfig. However, I'll move the json loader on_init as suggestion in README of svlangserver unless lspconfig provides official project local settings loader similar to coc.nvim. Or most of SystemVerilog projects won't work in the default settings of svlangserver

[henry-hsieh]

As I mentioned in imc-trading/svlangserver#22, .svlangserver is used for root_dir detection.

[williamboman]

The svlangserver relies LSP client (vscode, coc.nvim, etc.) to provide project local setting.

I see. What kind of project-local settings does it need, are the default ones not sufficient? In the current on_init it seems like cmd, filetypes and settings are overridden. Since this function is invoked after the server has initialized, setting cmd and filetypes will not really achieve anything, so I assume it's the settings that is interesting here (btw I think there's a client.notify("workspace/didChangeConfiguration") missing at the end, to let the server know the settings have changed). If you want to achieve project-local settings via JSON, I'd personally recommend taking a look at https://github.com/tamago324/nlsp-settings.nvim, it'll most likely provide you with the mechanism you're looking for (if you don't want to use exrc).

[henry-hsieh]

What kind of project-local settings does it need, are the default ones not sufficient?

If default ones mean exrc, it's not secure (that's why Neovim deprecated it).

In the current on_init it seems like cmd, filetypes and settings are overridden. Since this function is invoked after the server has initialized, setting cmd and filetypes will not really achieve anything,

I didn't notice this, thanks for pointing out.

so I assume it's the settings that is interesting here (btw I think there's a client.notify("workspace/didChangeConfiguration") missing at the end, to let the server know the settings have changed).

Yes, you're right. Every project may have there settings. In addition to finding project's source files, the projects usually need macros to correctly configure the source files (similar to pass -DMACRO to C/C++ projects).

If you want to achieve project-local settings via JSON, I'd personally recommend taking a look at https://github.com/tamago324/nlsp-settings.nvim, it'll most likely provide you with the mechanism you're looking for (if you don't want to use exrc).

This is what I need. Thanks!