Added webfont fallbacks so Devanagari/Newa text doesn’t render as t…#241
Open
binamkayastha wants to merge 3 commits intomainfrom
Open
Added webfont fallbacks so Devanagari/Newa text doesn’t render as t…#241binamkayastha wants to merge 3 commits intomainfrom
binamkayastha wants to merge 3 commits intomainfrom
Conversation
…ofu boxes on machines without those fonts: `nepalingo-web/src/index.css:1` and `nepalingo-web/tailwind.config.ts:15`. - Ensured the random quote block uses the updated font stacks: `nepalingo-web/src/components/randomQuotes.tsx:13`. - Build passes: `pnpm -C nepalingo-web build`. - Created and checked out the requested branch: `fix-nepali-font`. If you want this to work fully offline too (no Google Fonts), tell me and I’ll switch to bundling `.woff2` fonts in `public/`.
Deploying nepalingo with
|
| Latest commit: |
67782e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0e27ce91.nepalingo.pages.dev |
| Branch Preview URL: | https://fix-nepali-font.nepalingo.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI generated fix for web fonts. Will manually test with cloudflare pages to make sure everything works. Unfortunately this has always worked on my laptop so I'll need someone who has had this problem before to check it.
Fixes 232