Skip to content

Conversation

hassen-doca
Copy link
Contributor

@hassen-doca hassen-doca commented Aug 7, 2025

Description

Describe:

Simple change that adds a proxies parameter to taiga client and requestmaker
Updated the affected existings tests, still thinking about the tests to add.
Not sure if this needs a usage documentation.

References

#55

Checklist

  • I have read the contribution guide
  • Code lint checked via inv lint
  • changes file included (see docs)
  • Usage documentation added in case of new features
  • Tests added

@protoroto
Copy link
Member

@hassen-doca Thanks for contributing! I'll try to make @yakky have a look at this as soon as possibile.
Just a minor thing, we try to "separate" the release part from the actual feature/bugfix implementation (we'll take care of the release once this is merged), so if you could remove the #d02d288 commit it would be great!

@hassen-doca
Copy link
Contributor Author

@protoroto sorry for the delay, done ✅

@coveralls
Copy link

Coverage Status

coverage: 97.97% (+0.004%) from 97.966%
when pulling 4655095 on hassen-doca:master
into fd2519a on nephila:master.

Copy link
Member

@yakky yakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hassen-doca for your contribution!

@protoroto protoroto merged commit 30c8e38 into nephila:master Aug 25, 2025
16 checks passed
@protoroto protoroto mentioned this pull request Aug 25, 2025
@protoroto
Copy link
Member

@hassen-doca I've just released 1.3.3 version ( https://pypi.org/project/python-taiga/1.3.3/ ) with your pr. Thanks again :)

@hassen-doca
Copy link
Contributor Author

Thanks for the fast response, hope we meet again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants