Skip to content

Conversation

@joewashear007
Copy link
Contributor

@joewashear007 joewashear007 commented Jul 30, 2025

Description

In my environment, I have multiple mcp server for various kubernetes clusters. They all take the same credentials, but the URL to connect with are different. The URL is determined from the user's AI prompt so I would like to be able to dynamically chose my MCP server. I have added an optional Override URL to the SSE & HTTP endpoints.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

How Has This Been Tested?

I have tested this in my local environment.

Checklist

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Release Notes

Screenshots (if applicable)

Summary by CodeRabbit

  • New Features

    • Added an optional "Uri Override" setting for custom URLs when using "sse" or "http" connection types.
  • Chores

    • Updated the application version to 0.1.30.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 30, 2025

Walkthrough

A new optional "Uri Override" string parameter was added to the McpClient node, allowing users to specify a custom URL for HTTP or SSE connection types. The code now uses this override if provided and valid; otherwise, it defaults to the URL from credentials. The package version was incremented from 0.1.29 to 0.1.30.

Changes

Cohort / File(s) Change Summary
McpClient Node: Uri Override Parameter
nodes/McpClient/McpClient.node.ts
Added an optional "Uri Override" property for HTTP/SSE connections; updated connection logic to validate and use this override URL if set, else fallback to credentials URL; throws error if override URL is invalid.
Package Version Bump
package.json
Incremented version from 0.1.29 to 0.1.30; no other changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A clever new path for the client to roam,
With "Uri Override," it finds a new home.
HTTP or SSE, just point and it goes—
No longer confined to the old URL it knows.
Version hops up, the code hops along,
Another small step in our rabbit's song! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b6bf8d and 9e8709b.

📒 Files selected for processing (1)
  • nodes/McpClient/McpClient.node.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • nodes/McpClient/McpClient.node.ts
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@joewashear007 joewashear007 marked this pull request as ready for review July 30, 2025 14:40
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0bcfd9 and c1552e5.

📒 Files selected for processing (2)
  • nodes/McpClient/McpClient.node.ts (3 hunks)
  • package.json (1 hunks)
🔇 Additional comments (3)
package.json (1)

3-3: LGTM - Appropriate version bump for new feature

The minor version increment correctly reflects the addition of the new URI override functionality.

nodes/McpClient/McpClient.node.ts (2)

93-104: Well-structured parameter definition

The new "Uri Override" parameter is properly configured with appropriate display options and clear description.


93-277: Feature implementation aligns well with PR objectives

The URI override functionality successfully addresses the use case of connecting to multiple MCP servers across different Kubernetes clusters with the same credentials but different URLs. The implementation is consistent and maintains backward compatibility.

joewashear007 and others added 2 commits July 30, 2025 10:47
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@iamfiscus iamfiscus merged commit c7b73cb into nerding-io:main Nov 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants