-
Notifications
You must be signed in to change notification settings - Fork 509
Added optional override for URL #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new optional "Uri Override" string parameter was added to the McpClient node, allowing users to specify a custom URL for HTTP or SSE connection types. The code now uses this override if provided and valid; otherwise, it defaults to the URL from credentials. The package version was incremented from 0.1.29 to 0.1.30. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
nodes/McpClient/McpClient.node.ts(3 hunks)package.json(1 hunks)
🔇 Additional comments (3)
package.json (1)
3-3: LGTM - Appropriate version bump for new featureThe minor version increment correctly reflects the addition of the new URI override functionality.
nodes/McpClient/McpClient.node.ts (2)
93-104: Well-structured parameter definitionThe new "Uri Override" parameter is properly configured with appropriate display options and clear description.
93-277: Feature implementation aligns well with PR objectivesThe URI override functionality successfully addresses the use case of connecting to multiple MCP servers across different Kubernetes clusters with the same credentials but different URLs. The implementation is consistent and maintains backward compatibility.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
In my environment, I have multiple mcp server for various kubernetes clusters. They all take the same credentials, but the URL to connect with are different. The URL is determined from the user's AI prompt so I would like to be able to dynamically chose my MCP server. I have added an optional Override URL to the SSE & HTTP endpoints.
Type of Change
How Has This Been Tested?
I have tested this in my local environment.
Checklist
Release Notes
Screenshots (if applicable)
Summary by CodeRabbit
New Features
Chores