Officially support Elixir 1.18 #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhunleth
requested review from
jjcarstens,
lawik,
mnishiguchi and
ConnorRigby
|
Oh, wow, there's a nontrivial CI failure. I'll get to fixing that! |
fhunleth
force-pushed
the
support-elixir-1.18
branch
from
81a44bf to
a83fe2b
Compare
fhunleth
force-pushed
the
support-elixir-1.18
branch
from
a83fe2b to
212fad6
Compare
Most libraries appear to work just fine with Elixir 1.18 and Nerves, so remove the warning when building.
fhunleth
force-pushed
the
support-elixir-1.18
branch
from
212fad6 to
3c0e041
Compare
It broke due to the new JSON.Encoder protocol, but it's not too hard of a fix.
|
Tests and Dialyzer pass now. The tests are a little on the flaky side, but I think that's been the case for a while. In any case, I don't think anything substantial has changed, and Elixir 1.18 has been working well for me in my usage. |
jjcarstens
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most libraries appear to work just fine with Elixir 1.18 and Nerves, so
remove the warning when building.