Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform using macro back to fix nerves_toolchain_ctng error #1047

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

fhunleth
Copy link
Member

This is a partial revert of e0e249d.

@fhunleth fhunleth requested a review from jjcarstens January 29, 2025 04:00
@@ -66,4 +66,15 @@ defmodule Nerves.Package.Platform do
artifact to the local build_path location.
"""
@callback build_path_link(package :: Nerves.Package.t()) :: build_path_link :: String.t()

# Deprecated. Avoid using in new code.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does @deprecated work for macros? Is it worth having a little warning?

@fhunleth fhunleth merged commit 7d01c20 into main Jan 29, 2025
5 of 6 checks passed
@fhunleth fhunleth deleted the using branch January 29, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants