Simplify Nerves.Env by removing package config caching #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like it was more useful when the Nerves package config was kept in `nerves.exs`. Now it's just returned from the Mix configuration. This opens up further simplifications since it's no longer important to make sure that the Agent is loaded. Performance-wise, it doesn't seem like the cache was used enough for anyone to notice.
jjcarstens
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like it was more useful when the Nerves package config was kept
in
nerves.exs. Now it's just returned from the Mix configuration. Thisopens up further simplifications since it's no longer important to make
sure that the Agent is loaded. Performance-wise, it doesn't seem like
the cache was used enough for anyone to notice.