Skip to content

Conversation

@clinssen
Copy link
Contributor

@clinssen clinssen commented Jan 14, 2026

Fixes #1260.
Fixes #1010.

@github-actions
Copy link

🐰 Bencher Report

Branch1295/merge
Testbedubuntu-latest

🚨 1 Alert

IterationBenchmarkMeasure
Units
ViewBenchmark Result
(Result Δ%)
Upper Boundary
(Limit %)
0tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapseLatency
seconds (s)
📈 plot
🚷 threshold
🚨 alert (🔔)
3.95 s
(+16.30%)Baseline: 3.40 s
3.74 s
(105.73%)

Click to view all benchmark results
BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
3.95 s
(+16.30%)Baseline: 3.40 s
3.74 s
(105.73%)

BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
3.26 s
(-3.76%)Baseline: 3.39 s
3.73 s
(87.49%)

BenchmarkLatencyBenchmark Result
seconds (s)
(Result Δ%)
Upper Boundary
seconds (s)
(Limit %)
tests/nest_continuous_benchmarking/test_nest_continuous_benchmarking.py::TestNESTContinuousBenchmarking::test_stdp_nn_synapse📈 view plot
🚷 view threshold
🚨 view alert (🔔)
3.24 s
(-4.33%)Baseline: 3.39 s
3.73 s
(86.97%)

🐰 View full continuous benchmarking report in Bencher

n_z integer = 2
tau_d ms = 0.4 ms
tau_r ms = 20 ms
V mV = 123 mV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we forbid this altogether? Users shouldn't be able to create variables with names that match unit types, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not tenable as many units use letter that will be commonly used as parameter names, like a, b, c, d. Hence the "if it's not defined as a variable, it's a unit" rule.


update:
integrate_odes() No newline at end of file
V = 1000 mV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when V = 1 V?

@clinssen clinssen changed the title Add coco that ensures that physical units are not assigned to Disambiguate physical units from declared variables Jan 16, 2026
@clinssen clinssen marked this pull request as draft January 16, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Assignment to physical unit should trigger error message Do not allow physical units to appear in expressions without a numeric literal in front

2 participants