-
Notifications
You must be signed in to change notification settings - Fork 54
Disambiguate physical units from declared variables #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| n_z integer = 2 | ||
| tau_d ms = 0.4 ms | ||
| tau_r ms = 20 ms | ||
| V mV = 123 mV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we forbid this altogether? Users shouldn't be able to create variables with names that match unit types, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not tenable as many units use letter that will be commonly used as parameter names, like a, b, c, d. Hence the "if it's not defined as a variable, it's a unit" rule.
|
|
||
| update: | ||
| integrate_odes() No newline at end of file | ||
| V = 1000 mV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when V = 1 V?
Fixes #1260.
Fixes #1010.