fix: consistently allow undefined as an app name for build command

nestjs · Jan 11, 2024 · 179f9c7 · 179f9c7
1 parent 258adc5
commit 179f9c7
Show file tree

Hide file tree

Showing 10 changed files with 18 additions and 16 deletions.
diff --git a/actions/build.action.ts b/actions/build.action.ts
@@ -82,9 +82,11 @@ export class BuildAction extends AbstractAction {
     const buildAll = commandOptions.find((opt) => opt.name === 'all')!
       .value as boolean;
 
-    let appNames: string[];
+    // undefined represents the default project, since we don't know its name here
+    let appNames: (string | undefined)[];
+
     if (buildAll) {
-      appNames = [undefined!]; // always include the default project
+      appNames = [undefined]; // always include the default project
 
       if (configuration.projects) {
         appNames.push(...Object.keys(configuration.projects));
@@ -175,7 +177,7 @@ export class BuildAction extends AbstractAction {
 
   private async runSwc(
     configuration: Required<Configuration>,
-    appName: string,
+    appName: string | undefined,
     pathToTsconfig: string,
     watchMode: boolean,
     options: Input[],
@@ -212,7 +214,7 @@ export class BuildAction extends AbstractAction {
 
   private async runWebpack(
     configuration: Required<Configuration>,
-    appName: string,
+    appName: string | undefined,
     commandOptions: Input[],
     pathToTsconfig: string,
     debug: boolean,
@@ -258,7 +260,7 @@ export class BuildAction extends AbstractAction {
     options: Input[],
     configuration: Required<Configuration>,
     pathToTsconfig: string,
-    appName: string,
+    appName: string | undefined,
   ) {
     if (watchMode) {
       const { WatchCompiler } = await import('../lib/compiler/watch-compiler');

diff --git a/lib/compiler/assets-manager.ts b/lib/compiler/assets-manager.ts
@@ -38,7 +38,7 @@ export class AssetsManager {
 
   public copyAssets(
     configuration: Required<Configuration>,
-    appName: string,
+    appName: string | undefined,
     outDir: string,
     watchAssetsMode: boolean,
   ) {

diff --git a/lib/compiler/compiler.ts b/lib/compiler/compiler.ts
@@ -18,7 +18,7 @@ export class Compiler extends BaseCompiler {
   public run(
     configuration: Required<Configuration>,
     tsConfigPath: string,
-    appName: string,
+    appName: string | undefined,
     _extras: any,
     onSuccess?: () => void,
   ) {

diff --git a/lib/compiler/helpers/get-builder.ts b/lib/compiler/helpers/get-builder.ts
@@ -12,7 +12,7 @@ import { getValueOrDefault } from './get-value-or-default';
 export function getBuilder(
   configuration: Required<Configuration>,
   cmdOptions: Input[],
-  appName: string,
+  appName: string | undefined,
 ) {
   const builderValue = getValueOrDefault<Builder>(
     configuration,

diff --git a/lib/compiler/helpers/get-tsc-config.path.ts b/lib/compiler/helpers/get-tsc-config.path.ts
@@ -13,7 +13,7 @@ import { getValueOrDefault } from './get-value-or-default';
 export function getTscConfigPath(
   configuration: Required<Configuration>,
   cmdOptions: Input[],
-  appName: string,
+  appName: string | undefined,
 ) {
   let tsconfigPath = getValueOrDefault<string | undefined>(
     configuration,

diff --git a/lib/compiler/helpers/get-webpack-config-path.ts b/lib/compiler/helpers/get-webpack-config-path.ts
@@ -12,7 +12,7 @@ import { getValueOrDefault } from './get-value-or-default';
 export function getWebpackConfigPath(
   configuration: Required<Configuration>,
   cmdOptions: Input[],
-  appName: string,
+  appName: string | undefined,
 ) {
   let webpackPath = getValueOrDefault<string | undefined>(
     configuration,

diff --git a/lib/compiler/swc/swc-compiler.ts b/lib/compiler/swc/swc-compiler.ts
@@ -39,7 +39,7 @@ export class SwcCompiler extends BaseCompiler {
   public async run(
     configuration: Required<Configuration>,
     tsConfigPath: string,
-    appName: string,
+    appName: string | undefined,
     extras: SwcCompilerExtras,
     onSuccess?: () => void,
   ) {
@@ -79,13 +79,13 @@ export class SwcCompiler extends BaseCompiler {
   private runTypeChecker(
     configuration: Required<Configuration>,
     tsConfigPath: string,
-    appName: string,
+    appName: string | undefined,
     extras: SwcCompilerExtras,
   ) {
     if (extras.watch) {
       const args = [
         tsConfigPath,
-        appName,
+        appName ?? 'undefined',
         configuration.sourceRoot ?? 'src',
         JSON.stringify(configuration.compilerOptions.plugins ?? []),
       ];

diff --git a/lib/compiler/watch-compiler.ts b/lib/compiler/watch-compiler.ts
@@ -35,7 +35,7 @@ export class WatchCompiler extends BaseCompiler<TypescriptWatchCompilerExtras> {
   public run(
     configuration: Required<Configuration>,
     tsConfigPath: string,
-    appName: string,
+    appName: string | undefined,
     extras: TypescriptWatchCompilerExtras,
     onSuccess?: () => void,
   ) {

diff --git a/lib/compiler/webpack-compiler.ts b/lib/compiler/webpack-compiler.ts
@@ -37,7 +37,7 @@ export class WebpackCompiler extends BaseCompiler<WebpackCompilerExtras> {
   public run(
     configuration: Required<Configuration>,
     tsConfigPath: string,
-    appName: string,
+    appName: string | undefined,
     extras: WebpackCompilerExtras,
     onSuccess?: () => void,
   ) {

diff --git a/lib/compiler/workspace-utils.ts b/lib/compiler/workspace-utils.ts
@@ -5,7 +5,7 @@ import { getValueOrDefault } from './helpers/get-value-or-default';
 export class WorkspaceUtils {
   public async deleteOutDirIfEnabled(
     configuration: Required<Configuration>,
-    appName: string,
+    appName: string | undefined,
     dirPath: string,
   ) {
     const isDeleteEnabled = getValueOrDefault<boolean>(