fix: Resolve absolute path for start
action
#2228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
start
command breaks whennest start
is executed with bun (bunx nest start
). This is because Node supports running a file w/o an extension (node /path/to/dist/main
) but Bun requires an extension.Issue Number: N/A
What is the new behavior?
Per #2223
This uses
require.resolve
to resolve the entrypoint to an absolute file path before starting the child process.Before:
/Users/colinmcd94/Documents/repos/nest-cli/nest-app/dist/main
After:
/Users/colinmcd94/Documents/repos/nest-cli/nest-app/dist/main.js
This will behave identically to before when using Node, and fixes the command for Bun.
Does this PR introduce a breaking change?
Other information