Skip to content

Fixes #18949: Add missing GraphQL ContactsMixin in types with ContactAssignments #18974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

Fixes #18949: Add missing GraphQL ContactsMixin in types with ContactAssignments #18974

merged 1 commit into from
Mar 21, 2025

Conversation

YiPrograms
Copy link
Contributor

Fixes: #18949

  • Add missing ContactMixin in GraphQL for all the types that have ContactMixin in models/ but not in graphql/types.py.

@YiPrograms YiPrograms marked this pull request as ready for review March 21, 2025 14:41
@jnovinger jnovinger self-requested a review March 21, 2025 16:40
jnovinger
jnovinger previously approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@jnovinger jnovinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @YiPrograms !

@YiPrograms YiPrograms force-pushed the 18949-fix-graphql-contactmixin branch from 3466a06 to 2c55bc9 Compare March 21, 2025 17:45
@YiPrograms
Copy link
Contributor Author

Sorry, i've found that the import is not in alphabetical order.
Updated it now.

@YiPrograms YiPrograms requested a review from jnovinger March 21, 2025 17:47
@jnovinger
Copy link
Member

General note for when this causes a minor merge conflict when trying to incorporate this change in to the feature branch for 4.3, there is only a very slight conflict re: tenancy.graphql.types.TenantType.contacts that was introduced in #18701.

That change introduces the TenantType.contacts attribute directly to the type rather than using the mixin. It makes sense that we should re-use the mixin instead of a direct attribute definition.

@jnovinger
Copy link
Member

Sorry, i've found that the import is not in alphabetical order. Updated it now.

Much appreciated, I completely missed that. Was a little surprised when the review got dismissed as I was adding a related comment!

@YiPrograms
Copy link
Contributor Author

Sorry, i've found that the import is not in alphabetical order. Updated it now.

Much appreciated, I completely missed that. Was a little surprised when the review got dismissed as I was adding a related comment!

What a coincidence!
Sorry about that, I should have caught it earlier before you started reviewing.

@jnovinger jnovinger merged commit b1d014b into netbox-community:main Mar 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnovinger jnovinger jnovinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The TenantType in GraphQL is missing the contacts property
2 participants
@YiPrograms @jnovinger