Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RfC: #8423 Allow assigning Service to FHRP Group, in addition to Device and VirtualMachine #19005

Draft
wants to merge 1 commit into
base: feature
Choose a base branch
from
Draft

RfC: #8423 Allow assigning Service to FHRP Group, in addition to Device and VirtualMachine #19005

wants to merge 1 commit into from

Conversation

jnovinger
Copy link
Member

@jnovinger jnovinger commented Mar 25, 2025 •
edited
Loading

Fixes: #8423

  • Allow assigning Service to FHRP Group, in addition to Device and VirtualMachine
  • Changes relation type for all three to a single GenericForeignKey that is required
    • Has the same semantics as before, that were enforced in Service.clean(), now enforced by the GFK and in model forms
  • Patches up REST API and GraphQL representations
    • Does not currently allow adding/changing via API, only UI

@jnovinger jnovinger marked this pull request as draft March 25, 2025 15:17
@jnovinger jnovinger changed the title WIP: #8423 Allow assigning Service to FHRP Group, in addition to Device and VirtualMachine RfC: #8423 Allow assigning Service to FHRP Group, in addition to Device and VirtualMachine Mar 25, 2025
@jeremystretch jeremystretch requested review from jeremystretch and removed request for jeremystretch March 26, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jnovinger