-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Closed #9763: Treat IP ranges as fully populated #19064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should be a test_filteresets.IPRangeTestCase testing for mark_populated, there should be one for mark_utilized as well, not sure why the test verifier isn't picking up those filter test missing?
There is also the case where you can initially have mark_populated off, then add an IP Address to it, then edit it and make mark_populated True. In this case you can delete the IP Address but you can no longer edit it. Not sure if we want to dis-allow setting the flag if you already have IP addresses created under the range?
IMO it makes sense to disallow editing the IP address, but let's see what feedback we get during the beta. |
Fixes: #9763
mark_populated
boolean field to the IPRange modeladd_available_ipaddresses()
utility function withannotate_ip_space()
get_child_ranges()
method the Prefix model to allow passing filtersNote: Calling
get_available_ips()
on a prefix withmark_utilized=True
no longer automatically returns an empty IPSet. This is a deviation from the current behavior that, while not explicitly addressed in the FR, is necessary to ensure the consistent treatment of both prefixes and IP ranges.