-
Notifications
You must be signed in to change notification settings - Fork 2.8k
20048 cleanup get_viewname URL resolution #20050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arthanson
wants to merge
10
commits into
feature
Choose a base branch
from
20048-viewname
base: feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20048
adds a
get_action_url
to replace theget_viewname
/ reverse sequence in the app, and allows it to be replaceable by models that need a different URL pattern then the standard.get_viewname
is used in two filtersviewname
andvalidated_viewname
which gets the viewname and then passes this to the url template tag so added in anaction_url
template tag (in netbox/utilities/templatetags/helpers.py) to use the get_action_url and have cleaner syntax goes from{% url object|viewname:'list' %}
to{% action_url object 'list' %}
. As a template tag it also supportsas
syntax so allows the following replacement:with cleaner:
netbox/extras/dashboard/widgets.py
needed the returned context changed as viewname isn't returned anymore but the template just uses it in an error message, so just updated the error message.NetBoxFeatureSet still uses get_viewname in the get_absolute_url function, but that is fine as any model that is overriding _get_action_url would also override get_absoulte_url as well so it doesn't need to be changed there.
NetBoxAPIHyperlinkedIdentityField and NetBoxURLHyperlinkedIdentityField also use get_viewname and there isn't a good way around that, but if needed any plugin should be able to override those as needed.