feat: improve helm chart postgresql secret handling #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecdobry
requested review from
jajeffries,
leoparente,
ltucker,
mfiedorowicz and
MicahParks
as code owners
|
|
ecdobry
force-pushed
the
ecdobry/postgres_secrets
branch
from
fd02648 to
7db0d30
Compare
MicahParks
approved these changes
Sep 16, 2025
ecdobry
force-pushed
the
ecdobry/postgres_secrets
branch
from
7db0d30 to
f4ca8c2
Compare
ecdobry
force-pushed
the
ecdobry/postgres_secrets
branch
from
f4ca8c2 to
a657830
Compare
ecdobry
changed the title
jajeffries
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention behind this pull request is to get diode's chart more inline with how the netbox community chart handles postgresql secrets. While not exactly the same, the goal is to create some familiarity between the two.
Additionally if a consumer of this chart were to leverage an external postgresql database, they would need to override environment variables to do so. This is less than ideal and these changes provide an easier mechanism to use external databases.
values.yaml:externalPostgresqlvalues: Added support for database, username, password, existingSecretName, and existingSecretKey fields in values.yaml_helpers.tpl:diode.postgresql.database- Returns database name (built-in or external)diode.postgresql.username- Returns username (built-in or external)diode.postgresql.secretname- Returns appropriate secret name based on configurationdiode.postgresql.secretkey- Returns appropriate secret key based on configurationdiode-secrets.yaml: creates external postgresql secrets when neededdiode-reconciler-deployment.yaml: properly references postgresql passwords from secretsdiode-reconciler-configmap.yaml: uses helper templates for consistent database/username configuration