Skip to content

Conversation

@jotak
Copy link
Member

@jotak jotak commented Oct 20, 2025

Description

In topology, automatically default to namespaces group when available
More logic can easily be inserted later if we want other default groups depending on the scope.

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Currently automatically groups as namespaces when available
More logic can easily be inserted
@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jpinsonneau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.82%. Comparing base (418cd67) to head (779616e).
⚠️ Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (418cd67) and HEAD (779616e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (418cd67) HEAD (779616e)
uitests 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
- Coverage   53.20%   46.82%   -6.39%     
==========================================
  Files         205       40     -165     
  Lines       11115     3498    -7617     
  Branches     1295        0    -1295     
==========================================
- Hits         5914     1638    -4276     
+ Misses       4689     1691    -2998     
+ Partials      512      169     -343     
Flag Coverage Δ
uitests ?
unittests 46.82% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 166 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jotak jotak changed the title New auto group Topology, automatic grouping Oct 21, 2025
@jotak jotak marked this pull request as ready for review October 21, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant