DefinitionSchema: better exception on empty definition

nette · Sep 29, 2021 · 3c615cb · 3c615cb
1 parent cc7c4e7
commit 3c615cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/DI/Config/DefinitionSchema.php b/src/DI/Config/DefinitionSchema.php
@@ -159,6 +159,9 @@ private function sniffType($key, array $def): string
 		} elseif (isset($def['imported'])) {
 			return Definitions\ImportedDefinition::class;
 
+		} elseif (!$def) {
+			throw new Nette\DI\InvalidConfigurationException("Service '$key': Empty definition.");
+
 		} else {
 			return Definitions\ServiceDefinition::class;
 		}

diff --git a/tests/DI/Compiler.missingDefinition.phpt b/tests/DI/Compiler.missingDefinition.phpt
@@ -14,12 +14,12 @@ Assert::throws(function () {
 	services:
 		-
 	');
-}, Nette\InvalidStateException::class, 'Factory and type are missing in definition of service.');
+}, Nette\InvalidStateException::class, "Service '0': Empty definition.");
 
 
 Assert::throws(function () {
 	createContainer(new DI\Compiler, '
 	services:
 		foo:
 	');
-}, Nette\InvalidStateException::class, "Service 'foo': Factory and type are missing in definition of service.");
+}, Nette\InvalidStateException::class, "Service 'foo': Empty definition.");