Resolver::resolveEntityType() ignores return types 'object' & 'mixed' […

…Closes #274]
nette · Dec 14, 2021 · bc57e3c · bc57e3c
1 parent 687b8af
commit bc57e3c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/DI/Resolver.php b/src/DI/Resolver.php
@@ -130,7 +130,7 @@ public function resolveEntityType(Statement $statement): ?string
 			$this->addDependency($reflection);
 
 			$type = Nette\Utils\Type::fromReflection($reflection) ?? Helpers::getReturnTypeAnnotation($reflection);
-			if ($type) {
+			if ($type && !in_array((string) $type, ['object', 'mixed'])) {
 				return Helpers::ensureClassType($type, sprintf('return type of %s()', Callback::toString($entity)));
 			}
 

diff --git a/tests/DI/ContainerBuilder.resolveTypes.phpt b/tests/DI/ContainerBuilder.resolveTypes.phpt
@@ -60,6 +60,12 @@ class Factory
 	}
 
 
+	public function createObjectNullable(): ?object
+	{
+		return (object) null;
+	}
+
+
 	/** @return mixed */
 	public function createMixedPhpDoc()
 	{
@@ -141,7 +147,14 @@ Assert::exception(function () {
 	$builder->addDefinition('a')
 		->setFactory([Factory::class, 'createObject']);
 	$container = createContainer($builder);
-}, Nette\DI\ServiceCreationException::class, "Service 'a': Return type of Factory::createObject() is not expected to be nullable/union/intersection/built-in, 'object' given.");
+}, Nette\DI\ServiceCreationException::class, "Service 'a': Unknown service type, specify it or declare return type of factory.");
+
+Assert::exception(function () {
+	$builder = new DI\ContainerBuilder;
+	$builder->addDefinition('a')
+		->setFactory([Factory::class, 'createObjectNullable']);
+	$container = createContainer($builder);
+}, Nette\DI\ServiceCreationException::class, "Service 'a': Return type of Factory::createObjectNullable() is not expected to be nullable/union/intersection/built-in, '?object' given.");
 
 Assert::exception(function () {
 	$builder = new DI\ContainerBuilder;
@@ -155,7 +168,7 @@ Assert::exception(function () {
 	$builder->addDefinition('a')
 		->setFactory([Factory::class, 'createMixed']);
 	$container = createContainer($builder);
-}, Nette\DI\ServiceCreationException::class, "Service 'a': Return type of Factory::createMixed() is not expected to be nullable/union/intersection/built-in, 'mixed' given.");
+}, Nette\DI\ServiceCreationException::class, "Service 'a': Unknown service type, specify it or declare return type of factory.");
 
 Assert::exception(function () {
 	$builder = new DI\ContainerBuilder;