Fix protocol spelling in hp_comware disp ip interface #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CursedEnvy
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
|
This will be a breaking change. |
|
Tests are failing. Probably need to update the test YAML files. |
Aaah my bad, indeed did not think of those, I've updated them . |
mjbear
changed the title
mjbear
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy to miss, but protocal seems a misspelling of protocol
the "display_ip_interface" template for example uses PROTOCOL_STATUS
This seems a typo to me, other templates use protocol instead of protocal.