Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Huawei VRP display bgp peer template #2085

Closed

Conversation

brian-s-cao
Copy link

No description provided.

@mjbear
Copy link
Collaborator

mjbear commented Mar 23, 2025

Hello @brian-s-cao
Thank you for your contribution!
I'm a volunteer and at a broad level there are a few things necessary to make this successful.

  • Please submit one template per pull request (PR).
  • General contributing guidelines.
  • Test data is necessary for most (if not all) contributions to confirm with a high certainty that no regressions and unintended breakage occurs.
  • Helper scripts exist to make the creation of the structured data simple, but still require the contributor to review so the output is as intended.

@mjbear mjbear added the status: action required This issue requires additional information to be actionable label Mar 23, 2025
@brian-s-cao
Copy link
Author

Hello @mjbear
The template and test data have been added, please check if there are any problems.
Thank you!

@brian-s-cao
Copy link
Author

Hello @mjbear
Please check the latest submitted Huawei VRP templates.
Thank you!

@mjbear
Copy link
Collaborator

mjbear commented Mar 27, 2025

Hello @mjbear Please check the latest submitted Huawei VRP templates. Thank you!

Hello @brian-s-cao

  • We want one template per pull request to make it easier promptly review and test.
  • One template per PR gives you the opportunity to apply suggested improvements to other templates/files based on the first one or two the maintainers review.

Would you be able to please reduce this PR down to the huawei_vrp_display_bgp_peer template with its related index update and test data?

@brian-s-cao brian-s-cao changed the title Update Huawei VRP templates Add Huawei VRP display bgp peer template Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: action required This issue requires additional information to be actionable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants