Skip to content

Error when configs are created with unrecognized fields #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Jul 10, 2025

Purpose

  • Catch issues where users/implementers pass misspelled kwargs to configs

Changes

  • Add extra="forbid" to QuantizationConfig, QuantizationScheme, QuantizationArgs, TransformConfig, TransformScheme, and TransformArgs
  • Add a dummy arg run_compressed to QuantizationConfig
  • Fix typos in existing tests
  • Apply style

Testing

Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this needs to be rebased after your other PR is merged?

Copy link
Contributor

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this has other changes from formatting and the randomized->randomize refactor in transforms 🤷

@dsikka
Copy link
Collaborator

dsikka commented Jul 30, 2025

Can you resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants