Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX correct the invoke of oblique trees by feature combinations #347

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

FIX correct the invoke of oblique trees by feature combinations #347

wants to merge 1 commit into from

Conversation

mamamum
Copy link

@mamamum mamamum commented Feb 19, 2025

Reference Issues/PRs

args feature_combinations in multiview tree is not in use

What does this implement/fix? Explain your changes.

Now feature_combinations can be correctly given to feature_combinations_, if input feature_combinations is None, it will be defaultly set 1, which means not using oblique method

Any other comments?

PSSF23
PSSF23 requested changes Feb 20, 2025
View reviewed changes
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can put default hyperparameter in the init function instead of setting it specifically. Just make it feature_combinatinos=1 instead of None.

@PSSF23 PSSF23 changed the title make feature_combinations into use FIX correct the invoke of oblique trees by feature combinations Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSSF23 PSSF23 PSSF23 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamamum @PSSF23