FIX implement additional fix for pruning

meson.build

@@ -4,7 +4,7 @@ project(
   # Note that the git commit hash cannot be added dynamically here
   # That only happens when importing from a git repository.
   # See `treeple/__init__.py`
-  version: '0.10.2',
+  version: '0.10.3',
   license: 'PolyForm Noncommercial 1.0.0',
   meson_version: '>= 1.1.0',
   default_options: [

pyproject.toml

@@ -17,7 +17,7 @@ requires = [
 
 [project]
 name = "treeple"
-version = "0.10.2"
+version = "0.10.3"
 description = "Modern decision trees in Python"
 maintainers = [
   {name = "Neurodata", email = "[email protected]"}

treeple/__init__.py

@@ -4,7 +4,7 @@
 import os
 import sys
 
-__version__ = "0.10.2"
+__version__ = "0.10.3"
 logger = logging.getLogger(__name__)
 
 

treeple/tree/honesty/_honest_prune.pyx

@@ -368,8 +368,13 @@ cdef _honest_prune(
             split_is_degenerate = (
                 pruner.n_left_samples() == 0 or pruner.n_right_samples() == 0
             )
-            is_leaf_in_origtree = child_l[node_idx] == _TREE_LEAF
+            # is_leaf_in_origtree = child_l[node_idx] == _TREE_LEAF
+            # consider whether left or right children node is a leaf node.
+            is_leaf_in_origtree = (child_l[node_idx] == _TREE_LEAF and child_r[node_idx] == _TREE_LEAF)
+
             if invalid_split or split_is_degenerate or is_leaf_in_origtree:
+                # invalid_split or is_leaf_in_origtree:
+                # or split_is_degenerate or is_leaf_in_origtree:
                 # ... and child_r[node_idx] == _TREE_LEAF:
                 #
                 # 1) if node is not degenerate, that means there are still honest-samples in