Skip to content

Conversation

yahmed153
Copy link
Collaborator

@yahmed153 yahmed153 commented Jun 9, 2025

Links

https://new-relic.atlassian.net/browse/NR-354877

Details

Added Custom Attributes via environment variable NEW_RELIC_APPLICATION_LOGGING_FORWARDING_CUSTOM_ATTRIBUTES or programmatically. Format of key/value is key1:val1;key2:val2;....

@yahmed153 yahmed153 changed the base branch from master to develop June 9, 2025 17:11
@yahmed153 yahmed153 marked this pull request as draft June 9, 2025 17:17
@yahmed153
Copy link
Collaborator Author

TODO: Add link to docs like Labels

@Newrelic-Boomi
Copy link

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.40%. Comparing base (58fb0b0) to head (9790046).
Report is 33 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #1041       +/-   ##
============================================
+ Coverage    63.73%   77.40%   +13.66%     
============================================
  Files          217      113      -104     
  Lines        17921    12702     -5219     
============================================
- Hits         11422     9832     -1590     
+ Misses        6075     2539     -3536     
+ Partials       424      331       -93     

see 330 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 949c6d8...9790046. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yahmed153 yahmed153 requested a review from nr-swilloughby June 10, 2025 15:32
@yahmed153 yahmed153 marked this pull request as ready for review June 10, 2025 15:33
@yahmed153
Copy link
Collaborator Author

@nr-swilloughby would we need to add CustomAttributes to this struct

@yahmed153
Copy link
Collaborator Author

yahmed153 commented Jun 10, 2025

Creating PRs for AgentSpec and DocsSite as well

DocSIte PR

@nr-swilloughby
Copy link
Contributor

@nr-swilloughby would we need to add CustomAttributes to this struct

I don't think we necessarily do, but that's a good question. We don't normally add things there for every feature we add. The items there are specifically the values that show up at the top level of the configuration values for the agent's connect payload, and are extracted from the Config struct. However, as you can see the entire Config struct is also included as the settings value of that data structure itself anyway, so your values are already in there automatically, just deeper down inside the struct. So unless there's a specific reason to bring a value up to the top level, we don't need to do anything and they'll just show up in the general settings value.

@yahmed153 yahmed153 requested a review from nr-swilloughby June 13, 2025 15:50
@yahmed153 yahmed153 merged commit 3e14d2b into develop Jun 24, 2025
58 of 59 checks passed
@yahmed153 yahmed153 deleted the logging-custom-attributes branch June 24, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants