Skip to content

Replace HandlerInterceptorPointCut with weaver instrumentation#2871

Merged
jtduffy merged 2 commits into
mainfrom
handler-int-pointcut-module
May 15, 2026
Merged

Replace HandlerInterceptorPointCut with weaver instrumentation#2871
jtduffy merged 2 commits into
mainfrom
handler-int-pointcut-module

Conversation

@jtduffy

@jtduffy jtduffy commented May 8, 2026

Copy link
Copy Markdown
Contributor

Resolves #2849

Replaces the HandlerInterceptorPointcut with a weaver module.

One side effect - the roll-up metric Spring/HandlerInterceptor is now un-scoped because of the use of the traced method API rather than on the DefaultTracer instance. A correction to the one broken AIT will be issued soon.

@codecov-commenter

codecov-commenter commented May 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.73%. Comparing base (84147ad) to head (b18ee5a).
⚠️ Report is 39 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2871      +/-   ##
============================================
+ Coverage     70.63%   70.73%   +0.10%     
- Complexity    10636    10650      +14     
============================================
  Files           881      880       -1     
  Lines         42947    42942       -5     
  Branches       6501     6501              
============================================
+ Hits          30334    30374      +40     
+ Misses         9679     9643      -36     
+ Partials       2934     2925       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jtduffy jtduffy merged commit deb8694 into main May 15, 2026
251 of 253 checks passed
@github-project-automation github-project-automation Bot moved this from Triage to Code Complete/Done in Java Engineering Board May 15, 2026
@jtduffy jtduffy deleted the handler-int-pointcut-module branch May 15, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Replace HandlerInterceptorPointCut with weaver instrumentation

3 participants