1단계 - 문자열계산기 #3987
Merged
1단계 - 문자열계산기 #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nooose
requested changes
Mar 21, 2025
nooose
approved these changes
Mar 22, 2025
Comment on lines
+13
to
+14
| Operator operator = new Operator(expressions.get(i)); | ||
| result = operator.operate(result, new Operand(expressions.get(i + 1))); |
There was a problem hiding this comment.
Operator를 반복마다 인스턴스화 할 필요없을 것 같기도하네요 🤔
Operator는 Operation을 꺼내오는 팩토리 역할로만 사용해도 좋았을 것 같다는 의견을 드리고 싶습니다!
var operation = Operator.getOperation(symbol);
var result = operation.operate(operand1, operand2);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
가급적 수업 때 말씀하셨던 부분들을 지키려고 신경써보았습니다.