[1단계] - 학습 테스트 실습 #5877
Merged
[1단계] - 학습 테스트 실습 #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nooose
approved these changes
Mar 11, 2025
Comment on lines
+27
to
+34
| // given | ||
| int expected = 3; | ||
|
|
||
| // when | ||
| int sut = numbers.size(); | ||
|
|
||
| // then | ||
| assertThat(sut).isEqualTo(expected); |
There was a problem hiding this comment.
Suggested change
| // given | |
| int expected = 3; | |
| // when | |
| int sut = numbers.size(); | |
| // then | |
| assertThat(sut).isEqualTo(expected); | |
| assertThat(numbers).hasSize(3); |
이렇게도 사용해 보면 어떨까요?
| @ParameterizedTest | ||
| @ValueSource(ints = {1, 2, 3}) | ||
| void containsTest(int argument) { | ||
| assertThat(numbers.contains(argument)).isTrue(); |
There was a problem hiding this comment.
Suggested change
| assertThat(numbers.contains(argument)).isTrue(); | |
| assertThat(numbers).contains(argument); |
| String[] sut = str.split(","); | ||
|
|
||
| // then | ||
| assertAll(() -> assertThat(sut).contains("1", "2"), () -> assertThat(sut).containsExactly("1", "2")); |
There was a problem hiding this comment.
containsExactly 검증만으로 contains를 포함하고 있으니 contains 검증은 제거해도 좋습니다.
Suggested change
| assertAll(() -> assertThat(sut).contains("1", "2"), () -> assertThat(sut).containsExactly("1", "2")); | |
| assertThat(sut).containsExactly("1", "2"); |
|
|
||
| public class StringTest { | ||
|
|
||
| @DisplayName("1,2를 ','로 split 했을 때 1과 2로 잘 분리되는지 확인한다.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이번 미션 잘 부탁 드립니다 ~