Step3 #6123
Merged
Step3 #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nooose
approved these changes
Mar 25, 2025
| import racingcar.view.InputView; | ||
| import racingcar.view.ResultView; | ||
|
|
||
| public class Main { |
There was a problem hiding this comment.
테스트 케이스 잘 작성해 주신 것 처럼
README.md 에도 내가 처리할 요구사항을 먼저 정리해 보면 어떨까 싶어요!
- 기능을 구현하기 전에 README.md 파일에 구현할 기능 목록을 정리해 추가한다.
- git의 commit 단위는 앞 단계에서 README.md 파일에 정리한 기능 목록 단위로 추가한다.
참고문서: AngularJS Commit Message Conventions
Comment on lines
+8
to
+9
| RacingGame racingGame = new RacingGame(new InputView(), new ResultView(), new JavaUtilRandomNumberGenerator()); | ||
| racingGame.play(); |
|
|
||
| import java.util.Random; | ||
|
|
||
| public class JavaUtilRandomNumberGenerator implements RandomNumberGenerator { |
There was a problem hiding this comment.
인터페이스 도출된 것은 너무 좋은데 네이밍이 쪼끔 아쉽네요!
BoundaryRandomNumberGenerator 같은 네이밍을 주면 더 자연스럽지 않을까요?
new BoundaryRandomNumberGenerator(범위)
참고만 해주세요~
Comment on lines
+18
to
+19
| @CsvSource({"2,false", "3,false", "4,true", "5,true", "6,true", "7,true", "8,true"}) | ||
| public void carIsMovableWhenRandomLTE4(int random, boolean expected) { |
There was a problem hiding this comment.
👍 👍
만약 범위가 1에서 1억 사이라면
모든 범위를 테스트하기에는 불가능할 것 같아요
4라는 수에 경계를 두고 전후만 체크한다면 어떨까요?
Comment on lines
+3
to
+13
| public class StubRandomNumberGenerator implements RandomNumberGenerator { | ||
| private int fixedValue; | ||
|
|
||
| public void setFixedValue(int fixedValue) { | ||
| this.fixedValue = fixedValue; | ||
| } | ||
|
|
||
| @Override | ||
| public int generate(int max) { | ||
| return fixedValue; | ||
| } |
Comment on lines
+21
to
+26
| public void play() { | ||
| inputView.initGameInput(); | ||
| initializeCars(inputView.getNumberOfCars()); | ||
| runRace(inputView.getAttemptCount()); | ||
| resultView.printResult(); | ||
| } |
There was a problem hiding this comment.
출력을 담당하는 객체가 상태를 계속 변경하고 유지하는 것보다는,
모델을 전달받아 출력만 담당하도록 설계하는 것이 더 나을 것 같습니다.
상태가 없다면 동일한 입력에 대해 항상 같은 출력을 보장할 수 있지 않을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.