Skip to content

refactor: adjust for Nextcloud 33 new files sidebar API #2300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 2 commits into from
Jan 5, 2026
Merged

refactor: adjust for Nextcloud 33 new files sidebar API #2300

susnux merged 2 commits into from
Jan 5, 2026
+506 −196

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jan 5, 2026

@susnux susnux added this to the Nextcloud 33 milestone Jan 5, 2026
@susnux susnux force-pushed the refactor/adjust-for-nc33 branch from 95d0805 to 991ccad Compare January 5, 2026 14:35
@cypress
Copy link

cypress bot commented Jan 5, 2026 •
edited
Loading

Activity    Run #3148

Run Properties:  status check passed Passed #3148  •  git commit cf870ab187: refactor: adjust for Nextcloud 33 new files sidebar API
Project Activity
Branch Review refactor/adjust-for-nc33
Run status status check passed Passed #3148
Run duration 02m 20s
Commit git commit cf870ab187: refactor: adjust for Nextcloud 33 new files sidebar API
Committer Ferdinand Thiessen
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 9
View all changes introduced in this branch ↗︎

@susnux susnux force-pushed the refactor/adjust-for-nc33 branch 2 times, most recently from 5d925c4 to affe40e Compare January 5, 2026 14:53
@codecov
Copy link

codecov bot commented Jan 5, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utils/api.ts 0.00% 6 Missing ⚠️
src/components/ActivitySidebarPlugin.vue 0.00% 1 Missing ⚠️
src/views/ActivityTab.vue 90.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@susnux susnux force-pushed the refactor/adjust-for-nc33 branch from affe40e to 4de32e5 Compare January 5, 2026 15:29
@susnux susnux merged commit 8b55ce7 into master Jan 5, 2026
51 of 53 checks passed
@susnux susnux deleted the refactor/adjust-for-nc33 branch January 5, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@artonge artonge Awaiting requested review from artonge

@miaulalala miaulalala Awaiting requested review from miaulalala

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

3. to review bug

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux @AndyScherzinger