Skip to content

Fix avatar sizing for non-user avatars #16227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alperozturk96 merged 1 commit into from
Jan 12, 2026
Merged

Fix avatar sizing for non-user avatars #16227

alperozturk96 merged 1 commit into from
Jan 12, 2026
+7 −9

Conversation

@AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jan 1, 2026

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_20260101_183807 Screenshot_20260101_183553
  • Tests written, or not not needed

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.36.0 milestone Jan 1, 2026
@AndyScherzinger AndyScherzinger changed the title fix(avatar): Fix avatar sizing for non-user avatars Fix avatar sizing for non-user avatars Jan 1, 2026
@github-actions
Copy link

github-actions bot commented Jan 1, 2026

Codacy

SpotBugs

CategoryBaseNew
Bad practice4343
Correctness7474
Dodgy code257257
Experimental11
Internationalization77
Malicious code vulnerability33
Multithreaded correctness3434
Performance4444
Security1818
Total481481

@github-actions
Copy link

github-actions bot commented Jan 1, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16227.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@AndyScherzinger AndyScherzinger force-pushed the fix/noid/nonUserAvatars branch from d600f3c to 31d7d86 Compare January 12, 2026 13:04
@alperozturk96 alperozturk96 force-pushed the fix/noid/nonUserAvatars branch from 31d7d86 to ee69aac Compare January 12, 2026 13:49
alperozturk96
alperozturk96 approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you Andy

@alperozturk96 alperozturk96 merged commit 80d18ed into master Jan 12, 2026
11 of 20 checks passed
@alperozturk96 alperozturk96 deleted the fix/noid/nonUserAvatars branch January 12, 2026 13:53
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alperozturk96 alperozturk96 alperozturk96 approved these changes

@tobiasKaminsky tobiasKaminsky Awaiting requested review from tobiasKaminsky

Assignees

No one assigned

Labels

3. to review design

Projects

None yet

Milestone

Nextcloud App 3.36.0

Development

Successfully merging this pull request may close these issues.

3 participants

@AndyScherzinger @alperozturk96